Issue 239303004: Extract common code, add host IP to --debug and --enable-vm-service options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239303004: Extract common code, add host IP to --debug and --enable-vm-service options (Closed)

Created:
6 years, 8 months ago by kustermann

Modified:
6 years, 8 months ago

Reviewers:
Cutch, hausner

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -46 lines)			Patch
M	dart/runtime/bin/main.cc	View	1	6 chunks	+67 lines, -32 lines	0 comments	Download
M	dart/runtime/bin/vmservice/server.dart	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	dart/runtime/bin/vmservice/vmservice_io.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	dart/runtime/bin/vmservice_impl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	dart/runtime/bin/vmservice_impl.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	dart/tests/standalone/vmservice/test_helper.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

kustermann

There are situations in which we'd like to start the VM with non-127.0.0.1 IPs for ...

6 years, 8 months ago (2014-04-15 16:39:58 UTC) #1

kustermann

6 years, 8 months ago (2014-04-23 13:09:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r35312 (presubmit successful).