Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 23923005: Change --print-ast output to be more regular. (Closed)

Created:
7 years, 3 months ago by Kevin Millikin (Google)
Modified:
7 years, 3 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Change --print-ast output to be more regular. The print-ast output is useful for debugging front end issues. It is a mix of fully-parenthesized prefix notation (i.e., Lisp S-expressions) with some infix. It is not valid S-expressions for various other reasons. Most obviously, it uses ' (single quote) instead of " (double quote) to delimit strings. This change makes the print-ast output a valid Scheme S-expression. It can be pretty printed by copying it, quoting it (by preceding it with a single quote), and evaluating it at the REPL of a Scheme implementation. Also, the AST node pretty names are changed to predictably match the class name. It doesn't seem helpful to have them be arbitrary. BUG= R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=27282

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -171 lines) Patch
M runtime/vm/ast.h View 4 chunks +60 lines, -58 lines 0 comments Download
M runtime/vm/ast.cc View 3 chunks +17 lines, -14 lines 0 comments Download
M runtime/vm/ast_printer.h View 1 chunk +5 lines, -4 lines 0 comments Download
M runtime/vm/ast_printer.cc View 9 chunks +69 lines, -89 lines 1 comment Download
M runtime/vm/flow_graph_builder.h View 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
7 years, 3 months ago (2013-09-06 12:21:31 UTC) #1
regis
LGTM Thanks for doing this. Awesome! https://codereview.chromium.org/23923005/diff/1/runtime/vm/ast_printer.cc File runtime/vm/ast_printer.cc (right): https://codereview.chromium.org/23923005/diff/1/runtime/vm/ast_printer.cc#newcode30 runtime/vm/ast_printer.cc:30: // CodeGeneratorContext. Feel ...
7 years, 3 months ago (2013-09-06 16:27:34 UTC) #2
Kevin Millikin (Google)
7 years, 3 months ago (2013-09-09 10:21:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27282 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698