Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 239213004: Add a message for analysis server to indicate a successful connection. (Closed)

Created:
6 years, 8 months ago by Paul Berry
Modified:
6 years, 8 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a message for analysis server to indicate a successful connection. This complements the "server already started" error introduced in r35046. It's now easy for the client to detect whether a connection to the server was successful--it simply connects and waits for the initial message from the server. The message returned on a successful connection is: {"event":"server.connected"} R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=35108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Paul Berry
6 years, 8 months ago (2014-04-15 23:42:12 UTC) #1
Brian Wilkerson
LGTM
6 years, 8 months ago (2014-04-16 02:53:44 UTC) #2
Brian Wilkerson
Although, as I was about to add documentation for this I wondered whether this might ...
6 years, 8 months ago (2014-04-16 02:57:33 UTC) #3
Paul Berry
On 2014/04/16 02:57:33, Brian Wilkerson wrote: > Although, as I was about to add documentation ...
6 years, 8 months ago (2014-04-16 03:25:08 UTC) #4
Brian Wilkerson
> {"event":"connected","params":{}} I added the notification to the spec, but in keeping with the domain ...
6 years, 8 months ago (2014-04-16 14:04:09 UTC) #5
Paul Berry
6 years, 8 months ago (2014-04-16 15:11:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r35108 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698