Issue 239183005: Add a context field to Message in shelf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239183005: Add a context field to Message in shelf. (Closed)

Created:
6 years, 8 months ago by nweiz

Modified:
6 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org, andersmholmgren

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Add a context field to Message in shelf. Originally https://codereview.chromium.org/226263007/. BUG=https://code.google.com/p/dart/issues/detail?id=17992 R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=35102

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -30 lines)			Patch
M	AUTHORS	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/shelf/CHANGELOG.md	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/shelf/lib/src/message.dart	View	2 chunks	+18 lines, -2 lines	0 comments	Download
M	pkg/shelf/lib/src/request.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/shelf/lib/src/response.dart	View	9 chunks	+34 lines, -20 lines	0 comments	Download
M	pkg/shelf/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/shelf/test/message_test.dart	View	2 chunks	+26 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

kevmoo

LGTM May need to rebase on to latest. It did not cleanly merge for me. ...

6 years, 8 months ago (2014-04-16 00:56:24 UTC) #2

nweiz

6 years, 8 months ago (2014-04-16 01:23:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35102 (presubmit successful).