Issue 23913009: Add support for hidden options to pkg/args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23913009: Add support for hidden options to pkg/args. (Closed)

Created:
7 years, 2 months ago by nweiz

Modified:
7 years, 2 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add support for hidden options to pkg/args. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27853

Patch Set 1 #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -5 lines)			Patch
M	pkg/args/lib/args.dart	View	2 chunks	+6 lines, -4 lines	2 comments	Download
M	pkg/args/lib/src/options.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/args/lib/src/usage.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/args/test/usage_test.dart	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One suggestion then LGTM. https://codereview.chromium.org/23913009/diff/1/pkg/args/lib/args.dart File pkg/args/lib/args.dart (right): https://codereview.chromium.org/23913009/diff/1/pkg/args/lib/args.dart#newcode338 pkg/args/lib/args.dart:338: bool isHidden: false}) { Let's ...

7 years, 2 months ago (2013-09-24 20:57:07 UTC) #2

nweiz

https://codereview.chromium.org/23913009/diff/1/pkg/args/lib/args.dart File pkg/args/lib/args.dart (right): https://codereview.chromium.org/23913009/diff/1/pkg/args/lib/args.dart#newcode338 pkg/args/lib/args.dart:338: bool isHidden: false}) { On 2013/09/24 20:57:07, Bob Nystrom ...

7 years, 2 months ago (2013-09-24 21:01:17 UTC) #3

nweiz

7 years, 2 months ago (2013-09-24 21:02:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r27853 (presubmit successful).

Expand Messages | Collapse Messages