Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 23904023: Revert r27592, some unit tests fail. (Closed)

Created:
7 years, 3 months ago by ngeoffray
Modified:
7 years, 3 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert r27592, some unit tests fail. Committed: https://code.google.com/p/dart/source/detail?r=27593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -67 lines) Patch
M sdk/lib/_internal/compiler/implementation/closure.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolved_visitor.dart View 3 chunks +1 line, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 3 chunks +6 lines, -9 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart View 2 chunks +1 line, -9 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart View 3 chunks +4 lines, -10 lines 0 comments Download
D tests/language/assertion2_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
Committed patchset #1 manually as r27593 (presubmit successful).
7 years, 3 months ago (2013-09-18 07:27:27 UTC) #1
ngeoffray
TBR
7 years, 3 months ago (2013-09-18 07:27:36 UTC) #2
kasperl
7 years, 3 months ago (2013-09-18 07:35:07 UTC) #3
Message was sent while issue was closed.
LGTM :-(

Powered by Google App Engine
This is Rietveld 408576698