Issue 23904009: added one-liners: Node, EventTarget, Canvas, HttpClient, HttpServer etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23904009: added one-liners: Node, EventTarget, Canvas, HttpClient, HttpServer etc. (Closed)

Created:
7 years, 3 months ago by mem

Modified:
7 years, 3 months ago

Reviewers:
Kathy Walrath, shailentuli

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

added one-liners: Node, EventTarget, Canvas, HttpClient, HttpServer etc. BUG= R=kathyw@google.com Committed: https://code.google.com/p/dart/source/detail?r=27400

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -12 lines)			Patch
M	sdk/lib/core/double.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/core/stopwatch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		8 chunks	+33 lines, -7 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/io/http.dart	View		2 chunks	+8 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Kathy Walrath

lgtm, from a wording POV. I might break up and/or expand some of the descriptions ...

7 years, 3 months ago (2013-09-11 00:18:50 UTC) #2

mem

7 years, 3 months ago (2013-09-11 20:13:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r27400 (presubmit successful).