Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 23903020: Fix for CSS URIs not parsing correctly with innerHTML (Closed)

Created:
7 years, 3 months ago by blois
Modified:
7 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for CSS URIs not parsing correctly with innerHTML Chrome has a bug (https://code.google.com/p/chromium/issues/detail?id=229142) where CSS URIs are not converting correctly when an element is parsed in one document then moved to another document. This uses a base element to set the baseURI of the parse document so it doesn't need to be converted on clone. BUG=13147 R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=27305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +9 lines, -0 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 2 chunks +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 3 months ago (2013-09-09 17:56:17 UTC) #1
Jennifer Messerly
lgtm
7 years, 3 months ago (2013-09-09 18:04:50 UTC) #2
blois
7 years, 3 months ago (2013-09-09 19:06:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27305 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698