Issue 239003002: Reduce test.dart memory usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239003002: Reduce test.dart memory usage. (Closed)

Created:
6 years, 8 months ago by Bill Hesse

Modified:
6 years, 8 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reduce test.dart memory usage. BUG=18084 R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=35058

Patch Set 2 : Drop cachedTests when done. #

Patch Set 3 : Added cleared check. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -18 lines)			Patch
M	tools/testing/dart/multitest.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1 2	11 chunks	+21 lines, -8 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	7 chunks	+6 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

LGTM You could set the cachedTests to null in TestSuite after enqueueing, so we don't ...

6 years, 8 months ago (2014-04-15 12:06:59 UTC) #2

Bill Hesse

Addressed comments -did both. https://codereview.chromium.org/239003002/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/239003002/diff/1/tools/testing/dart/test_runner.dart#newcode585 tools/testing/dart/test_runner.dart:585: } On 2014/04/15 12:07:00, kustermann ...

6 years, 8 months ago (2014-04-15 12:37:30 UTC) #3