Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 23896002: Fix errors in dart:io tests found by the analyzer (Closed)

Created:
7 years, 3 months ago by Søren Gjesse
Modified:
7 years, 3 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix errors in dart:io tests found by the analyzer TBR=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M tests/standalone/io/file_non_ascii_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/io/http_client_request_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/standalone/io/raw_socket_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/io/raw_socket_typed_data_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M tests/standalone/io/socket_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 3 months ago (2013-09-03 14:02:12 UTC) #1
Søren Gjesse
Committed patchset #1 manually as r27057 (presubmit successful).
7 years, 3 months ago (2013-09-03 14:02:32 UTC) #2
Anders Johnsen
7 years, 3 months ago (2013-09-03 14:41:29 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698