Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 23890042: Move div by zero testing into its own test. (Closed)

Created:
7 years, 3 months ago by ngeoffray
Modified:
7 years, 3 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move div by zero testing into its own test. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=27746

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -96 lines) Patch
M tests/language/div_with_power_of_two_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
A + tests/language/integer_division_by_zero_test.dart View 1 chunk +3 lines, -93 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 3 months ago (2013-09-23 09:02:20 UTC) #1
karlklose
LGTM.
7 years, 3 months ago (2013-09-23 09:06:20 UTC) #2
ngeoffray
7 years, 3 months ago (2013-09-23 09:07:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27746 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698