Issue 23890008: Revert "Make LinkedHashMap also have a factory constructor and be customizable"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23890008: Revert "Make LinkedHashMap also have a factory constructor and be customizable" (Closed)

Created:
7 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 3 months ago

Reviewers:

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Make LinkedHashMap also have a factory constructor and be customizable" Dartium expectations expects "LinkedHashMap" and gets "_LinkedHashMap". Committed: https://code.google.com/p/dart/source/detail?r=27250

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+379 lines, -378 lines)			Patch
M	editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/java_core.dart	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	pkg/mdv/lib/src/template_iterator.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/serialization/lib/src/reader_writer.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/serialization/lib/src/serialization_helpers.dart	View	1 chunk	+61 lines, -0 lines	0 comments	Download
A	pkg/serialization/test/polyfill_identity_map_test.dart	View	1 chunk	+48 lines, -0 lines	0 comments	Download
M	runtime/lib/collection_patch.dart	View	13 chunks	+170 lines, -126 lines	0 comments	Download
M	sdk/lib/_internal/lib/collection_patch.dart	View	16 chunks	+35 lines, -146 lines	0 comments	Download
M	sdk/lib/collection/hash_map.dart	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	sdk/lib/collection/linked_hash_map.dart	View	2 chunks	+33 lines, -4 lines	0 comments	Download
M	sdk/lib/collection/splay_tree.dart	View	8 chunks	+12 lines, -31 lines	0 comments	Download
M	tests/corelib/map_test.dart	View	3 chunks	+2 lines, -51 lines	0 comments	Download
M	tests/language/issue10561_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/issue9949_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

7 years, 3 months ago (2013-09-06 14:32:35 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r27250 (presubmit successful).

Expand Messages | Collapse Messages