Issue 23889008: Move delete/deleteSync up to FileSystemEntity, with a shared documentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23889008: Move delete/deleteSync up to FileSystemEntity, with a shared documentation. (Closed)

Created:
7 years, 3 months ago by Anders Johnsen

Modified:
7 years, 3 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move delete/deleteSync up to FileSystemEntity, with a shared documentation. This also means that FileSystemEntity.delete(recursive: true) now will delete any object on disk, much like 'rm -r', without the need of wrapping it in a Directory object. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27196

Patch Set 1 #

Patch Set 2 : Style fixes. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -163 lines)			Patch
M	runtime/bin/directory_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/file_patch.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/lib/io_patch.dart	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/io/directory.dart	View		1 chunk	+0 lines, -37 lines	0 comments	Download
M	sdk/lib/io/directory_impl.dart	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/io/file.dart	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	1	2 chunks	+11 lines, -5 lines	0 comments	Download
M	sdk/lib/io/file_system_entity.dart	View	1	6 chunks	+112 lines, -73 lines	0 comments	Download
M	sdk/lib/io/link.dart	View		3 chunks	+9 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

7 years, 3 months ago (2013-09-05 14:54:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r27196 (presubmit successful).

Expand Messages | Collapse Messages