Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 23889005: Cleaning up a bunch of DOM generation tables (Closed)

Created:
7 years, 3 months ago by blois
Modified:
7 years, 3 months ago
Reviewers:
Emily Fortuna, Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Cleaning up a bunch of DOM generation tables Many unused keys and missing events, etc. BUG= R=efortuna@google.com, jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=27137

Patch Set 1 : #

Total comments: 9

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -405 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 15 chunks +65 lines, -210 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 11 chunks +60 lines, -53 lines 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 2 chunks +16 lines, -31 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 2 chunks +21 lines, -29 lines 0 comments Download
M tools/dom/docs/docs.json View 1 chunk +15 lines, -0 lines 0 comments Download
M tools/dom/dom.json View 7 chunks +22 lines, -1 line 0 comments Download
M tools/dom/scripts/dartgenerator.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/generator.py View 3 chunks +2 lines, -7 lines 0 comments Download
M tools/dom/scripts/htmleventgenerator.py View 1 4 chunks +7 lines, -0 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 7 chunks +7 lines, -5 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +21 lines, -19 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_Console.darttemplate View 2 chunks +8 lines, -0 lines 0 comments Download
D tools/dom/templates/html/impl/impl_ScriptProcessorNode.darttemplate View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
blois
7 years, 3 months ago (2013-09-04 01:03:51 UTC) #1
Jacob
lgtm
7 years, 3 months ago (2013-09-04 01:07:18 UTC) #2
Emily Fortuna
https://codereview.chromium.org/23889005/diff/3001/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart File sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart (left): https://codereview.chromium.org/23889005/diff/3001/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart#oldcode65 sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart:65: * * The [Lawndart](http://pub.dartlang.org/packages/lawndart) package, why no longer talk ...
7 years, 3 months ago (2013-09-04 17:23:32 UTC) #3
blois
https://codereview.chromium.org/23889005/diff/3001/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart File sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart (left): https://codereview.chromium.org/23889005/diff/3001/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart#oldcode65 sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart:65: * * The [Lawndart](http://pub.dartlang.org/packages/lawndart) package, On 2013/09/04 17:23:32, Emily ...
7 years, 3 months ago (2013-09-04 17:34:33 UTC) #4
Emily Fortuna
https://codereview.chromium.org/23889005/diff/3001/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart File sdk/lib/web_audio/dart2js/web_audio_dart2js.dart (right): https://codereview.chromium.org/23889005/diff/3001/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart#newcode1108 sdk/lib/web_audio/dart2js/web_audio_dart2js.dart:1108: @Experimental() // untriaged On 2013/09/04 17:34:33, blois wrote: > ...
7 years, 3 months ago (2013-09-04 17:39:59 UTC) #5
blois
https://codereview.chromium.org/23889005/diff/3001/tools/dom/scripts/htmleventgenerator.py File tools/dom/scripts/htmleventgenerator.py (right): https://codereview.chromium.org/23889005/diff/3001/tools/dom/scripts/htmleventgenerator.py#newcode180 tools/dom/scripts/htmleventgenerator.py:180: 'Performance.webkitresourcetimingbufferfull': ('resourceTimingBufferFull', 'Event'), On 2013/09/04 17:39:59, Emily Fortuna wrote: ...
7 years, 3 months ago (2013-09-04 18:17:35 UTC) #6
Emily Fortuna
I understand now. lgtm
7 years, 3 months ago (2013-09-04 18:20:32 UTC) #7
blois
7 years, 3 months ago (2013-09-04 18:31:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r27137 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698