Issue 23883004: Fix bug http://code.google.com/p/dart/issues/detail?id=12941 by doing speculative optimizations eve…

Issue 23883004: Fix bug http://code.google.com/p/dart/issues/detail?id=12941 by doing speculative optimizations eve… (Closed)

Created:
7 years, 3 months ago by ngeoffray

Modified:
7 years, 3 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug http://code.google.com/p/dart/issues/detail?id=12941 by doing speculative optimizations even if one class in the system implements the speculated type, but does not implement all its members. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=27128

Patch Set 4 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -37 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/bailout.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart	View	1 2 3	2 chunks	+6 lines, -24 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/forwarding_type_mask.dart	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/type_mask.dart	View	1 2 3	1 chunk	+2 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/union_type_mask.dart	View	1 2 3	1 chunk	+2 lines, -6 lines	0 comments	Download
A	tests/compiler/dart2js/bailout_indexable_test.dart	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

kasperl

Could you update the CL description? There's something missing in it (impossible to parse). https://codereview.chromium.org/23883004/diff/5001/sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart ...

7 years, 3 months ago (2013-09-04 12:25:33 UTC) #2

kasperl

https://codereview.chromium.org/23883004/diff/5001/sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart File sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart (right): https://codereview.chromium.org/23883004/diff/5001/sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart#newcode466 sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart:466: bool hasSelector(Selector selector, Compiler compiler) { Maybe rename this ...

7 years, 3 months ago (2013-09-04 12:33:21 UTC) #3

ngeoffray

Description updated, PTAL. https://codereview.chromium.org/23883004/diff/5001/sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart File sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart (right): https://codereview.chromium.org/23883004/diff/5001/sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart#newcode466 sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart:466: bool hasSelector(Selector selector, Compiler compiler) { ...

7 years, 3 months ago (2013-09-04 12:36:16 UTC) #4

kasperl

LGTM! https://codereview.chromium.org/23883004/diff/5002/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (right): https://codereview.chromium.org/23883004/diff/5002/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart#newcode564 sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:564: bool understandsSelector(Selector selector, Compiler compiler) { Would just ...

7 years, 3 months ago (2013-09-04 12:47:55 UTC) #5

ngeoffray

Thanks Kasper. https://codereview.chromium.org/23883004/diff/5002/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (right): https://codereview.chromium.org/23883004/diff/5002/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart#newcode564 sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:564: bool understandsSelector(Selector selector, Compiler compiler) { On ...

7 years, 3 months ago (2013-09-04 12:50:28 UTC) #6

ngeoffray

7 years, 3 months ago (2013-09-04 13:37:25 UTC) #7

Message was sent while issue was closed.

Committed patchset #4 manually as r27128 (presubmit successful).

Expand Messages | Collapse Messages