Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1106)

Issue 23883003: Revert "Add custom equals and hashCode for HashMap implementation." (Closed)

Created:
7 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 3 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert "Add custom equals and hashCode for HashMap implementation." Committed: https://code.google.com/p/dart/source/detail?r=27111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -536 lines) Patch
M runtime/lib/collection_patch.dart View 9 chunks +17 lines, -221 lines 0 comments Download
M sdk/lib/_internal/lib/collection_patch.dart View 9 chunks +18 lines, -68 lines 0 comments Download
M sdk/lib/collection/hash_map.dart View 3 chunks +40 lines, -6 lines 0 comments Download
M tests/corelib/map_test.dart View 3 chunks +0 lines, -241 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
7 years, 3 months ago (2013-09-04 11:16:56 UTC) #1
Lasse Reichstein Nielsen
Committed patchset #1 manually as r27111 (presubmit successful).
7 years, 3 months ago (2013-09-04 11:17:25 UTC) #2
Lasse Reichstein Nielsen
TBR
7 years, 3 months ago (2013-09-04 11:17:30 UTC) #3
floitsch
7 years, 3 months ago (2013-09-04 11:24:46 UTC) #4
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698