Issue 238813003: pkg/shelf: rename Stack to Pipeline

Issue 238813003: pkg/shelf: rename Stack to Pipeline (Closed)

Created:
6 years, 8 months ago by kevmoo

Modified:
6 years, 8 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/shelf: rename Stack to Pipeline BUG= https://code.google.com/p/dart/issues/detail?id=17994 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=35087

Patch Set 2 : nit #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -177 lines)			Patch
M	pkg/shelf/CHANGELOG.md	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/shelf/README.md	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/shelf/example/example_server.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/shelf/lib/shelf.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	pkg/shelf/lib/src/pipeline.dart	View		2 chunks	+11 lines, -11 lines	0 comments	Download
D	pkg/shelf/lib/src/stack.dart	View		1 chunk	+0 lines, -45 lines	0 comments	Download
M	pkg/shelf/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/shelf/test/create_middleware_test.dart	View		15 chunks	+15 lines, -15 lines	0 comments	Download
M	pkg/shelf/test/log_middleware_test.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
A +	pkg/shelf/test/pipeline_test.dart	View		5 chunks	+7 lines, -7 lines	0 comments	Download
D	pkg/shelf/test/stack_test.dart	View		1 chunk	+0 lines, -91 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/238813003/diff/1/pkg/shelf/CHANGELOG.md File pkg/shelf/CHANGELOG.md (right): https://codereview.chromium.org/238813003/diff/1/pkg/shelf/CHANGELOG.md#newcode3 pkg/shelf/CHANGELOG.md:3: * Renamed `Stack` to `Pipeline` Period

6 years, 8 months ago (2014-04-15 21:30:09 UTC) #2

kevmoo

https://codereview.chromium.org/238813003/diff/1/pkg/shelf/CHANGELOG.md File pkg/shelf/CHANGELOG.md (right): https://codereview.chromium.org/238813003/diff/1/pkg/shelf/CHANGELOG.md#newcode3 pkg/shelf/CHANGELOG.md:3: * Renamed `Stack` to `Pipeline` On 2014/04/15 21:30:09, nweiz ...

6 years, 8 months ago (2014-04-15 21:35:35 UTC) #3

kevmoo

6 years, 8 months ago (2014-04-15 21:35:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r35087 (presubmit successful).

Expand Messages | Collapse Messages