Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 23875033: Do not analyze assert when assertions are disabled. (Closed)

Created:
7 years, 3 months ago by ngeoffray
Modified:
7 years, 3 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not analyze assert when assertions are disabled. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=27592

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -15 lines) Patch
M sdk/lib/_internal/compiler/implementation/closure.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolved_visitor.dart View 3 chunks +5 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 3 chunks +9 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart View 2 chunks +9 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart View 3 chunks +10 lines, -4 lines 0 comments Download
A tests/language/assertion2_test.dart View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 3 months ago (2013-09-17 13:00:38 UTC) #1
kasperl
LGTM.
7 years, 3 months ago (2013-09-17 13:05:31 UTC) #2
ngeoffray
7 years, 3 months ago (2013-09-18 06:56:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r27592 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698