add enumerate to the default filter set

add enumerate to the default filter set

R=justinfagnani@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28358

[justinfagnani, 2013-09-17 21:45:05]

lgtm

https://chromiumcodereview.appspot.com/23874018/diff/1/pkg/polymer_expression...
File pkg/polymer_expressions/lib/polymer_expressions.dart (right):

https://chromiumcodereview.appspot.com/23874018/diff/1/pkg/polymer_expression...
pkg/polymer_expressions/lib/polymer_expressions.dart:41: new Map<String,
Object>.from(DEFAULT_GLOBALS) : globals;
I think I'd rather see the default globals set in PolymerElement, but I'm fine
either way.

[Jennifer Messerly, 2013-10-08 00:55:00]

https://chromiumcodereview.appspot.com/23874018/diff/1/pkg/polymer_expression...
File pkg/polymer_expressions/lib/polymer_expressions.dart (right):

https://chromiumcodereview.appspot.com/23874018/diff/1/pkg/polymer_expression...
pkg/polymer_expressions/lib/polymer_expressions.dart:41: new Map<String,
Object>.from(DEFAULT_GLOBALS) : globals;
On 2013/09/17 21:45:05, justinfagnani wrote:
> I think I'd rather see the default globals set in PolymerElement, but I'm fine
> either way.

yeah, I was kinda wondering that too. So far we don't have any syntax knowledge
in the Polymer library other than saying "new PolymerExpressions", so that's why
I'm leaning this way.

Definitely something we should bring up tomorrow when chatting with them. It
feels like there isn't an easy way to add a filter to the scope. The JS approach
of making it global doesn't seem good.

maybe if we had something like:

import 'package:quiver/quiver.dart' show enumerate;

class FancyButton extends PolymerElement {
  get templateGlobals => { 'enumerate': enumerate };
}

... would that be lightweight enough, I wonder?

[justinfagnani, 2013-10-08 00:57:06]

On 2013/10/08 00:55:00, John Messerly wrote:
>
https://chromiumcodereview.appspot.com/23874018/diff/1/pkg/polymer_expression...
> File pkg/polymer_expressions/lib/polymer_expressions.dart (right):
> 
>
https://chromiumcodereview.appspot.com/23874018/diff/1/pkg/polymer_expression...
> pkg/polymer_expressions/lib/polymer_expressions.dart:41: new Map<String,
> Object>.from(DEFAULT_GLOBALS) : globals;
> On 2013/09/17 21:45:05, justinfagnani wrote:
> > I think I'd rather see the default globals set in PolymerElement, but I'm
fine
> > either way.
> 
> yeah, I was kinda wondering that too. So far we don't have any syntax
knowledge
> in the Polymer library other than saying "new PolymerExpressions", so that's
why
> I'm leaning this way.
> 
> Definitely something we should bring up tomorrow when chatting with them. It
> feels like there isn't an easy way to add a filter to the scope. The JS
approach
> of making it global doesn't seem good.
> 
> maybe if we had something like:
> 
> import 'package:quiver/quiver.dart' show enumerate;
> 
> class FancyButton extends PolymerElement {
>   get templateGlobals => { 'enumerate': enumerate };
> }
> 
> ... would that be lightweight enough, I wonder?

Yeah, that's basically what I've proposed before, though I do wonder if that's
any better than just using instance methods...

[Jennifer Messerly, 2013-10-08 06:14:37]

Committed patchset #2 manually as r28358 (presubmit successful).