Issue 23872035: Emit compile-time error for 'static' formal parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23872035: Emit compile-time error for 'static' formal parameters. (Closed)

Created:
7 years, 3 months ago by karlklose

Modified:
7 years, 3 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Emit compile-time error for 'static' formal parameters. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=27796

Patch Set 2 : Add tests for members." #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -2 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
A	tests/language/static_parameter_test.dart	View	1	1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/23872035/diff/1/tests/language/static_parameter_test.dart File tests/language/static_parameter_test.dart (right): https://codereview.chromium.org/23872035/diff/1/tests/language/static_parameter_test.dart#newcode11 tests/language/static_parameter_test.dart:11: } Check formals of members as well.

7 years, 3 months ago (2013-09-23 07:58:11 UTC) #2

karlklose

Committed patchset #2 manually as r27796 (presubmit successful).

7 years, 3 months ago (2013-09-24 06:33:02 UTC) #3

karlklose

7 years, 3 months ago (2013-09-24 06:57:21 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/23872035/diff/1/tests/language/static_paramet...
File tests/language/static_parameter_test.dart (right):

https://codereview.chromium.org/23872035/diff/1/tests/language/static_paramet...
tests/language/static_parameter_test.dart:11: }
On 2013/09/23 07:58:11, Johnni Winther wrote:
> Check formals of members as well.

Done.

Expand Messages | Collapse Messages

Issue 23872035: Emit compile-time error for 'static' formal parameters. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add tests for members." #

Messages