Issue 23872005: Fix http://code.google.com/p/dart/issues/detail?id=13007 by introducing a new Marker value in the S…

Issue 23872005: Fix http://code.google.com/p/dart/issues/detail?id=13007 by introducing a new Marker value in the S… (Closed)

Created:
7 years, 3 months ago by ngeoffray

Modified:
7 years, 3 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix http://code.google.com/p/dart/issues/detail?id=13007 by introducing a new Marker value in the SsaValueRangeAnalyzer. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=27232

Patch Set 3 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -81 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart	View	1 2	7 chunks	+74 lines, -81 lines	0 comments	Download
	M	tests/compiler/dart2js/value_range_test.dart	View	1	3 chunks	+54 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM! https://codereview.chromium.org/23872005/diff/4003/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart File sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart (right): https://codereview.chromium.org/23872005/diff/4003/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart#newcode1002 sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart:1002: return operation.operation(info.constantSystem).apply( I'd put operation.operation(info.constantSystem) in a local ...

7 years, 3 months ago (2013-09-06 08:20:02 UTC) #2

ngeoffray

Thanks Kasper. https://codereview.chromium.org/23872005/diff/4003/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart File sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart (right): https://codereview.chromium.org/23872005/diff/4003/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart#newcode1002 sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart:1002: return operation.operation(info.constantSystem).apply( On 2013/09/06 08:20:02, kasperl wrote: ...

7 years, 3 months ago (2013-09-06 08:36:08 UTC) #3

ngeoffray

7 years, 3 months ago (2013-09-06 08:41:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r27232 (presubmit successful).

Expand Messages | Collapse Messages