Issue 23868034: Remove spawnDomFunction from dart:html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23868034: Remove spawnDomFunction from dart:html (Closed)

Created:
7 years, 3 months ago by vsm

Modified:
7 years, 3 months ago

Reviewers:
floitsch, blois

CC:
reviews_dartlang.org, siva

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove spawnDomFunction from dart:html Note, spawnDomFunction is still used under the hood in Dartium to implement Timers and printing in background isolates. I don't think this is necessary, but I'll clean up in a separate CL once we decide what we're doing with background isolates. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=27577

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -520 lines)			Patch
D	samples/isolate_html/README	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	samples/isolate_html/app.yaml	View	1 chunk	+0 lines, -16 lines	0 comments	Download
D	samples/isolate_html/deploy.sh	View	1 chunk	+0 lines, -24 lines	0 comments	Download
D	samples/isolate_html/isolate_sample.css	View	1 chunk	+0 lines, -77 lines	0 comments	Download
D	samples/isolate_html/isolate_sample.dart	View	1 chunk	+0 lines, -131 lines	0 comments	Download
D	samples/isolate_html/isolate_sample.html	View	1 chunk	+0 lines, -55 lines	0 comments	Download
D	samples/isolate_html/main.py	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	sdk/lib/_internal/lib/isolate_helper.dart	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	3 chunks	+21 lines, -21 lines	0 comments	Download
D	tests/html/dom_isolates_test.dart	View	1 chunk	+0 lines, -81 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/html/js_interop_4_test.dart	View	2 chunks	+0 lines, -33 lines	0 comments	Download
M	tools/dom/src/native_DOMImplementation.dart	View	2 chunks	+21 lines, -2 lines	0 comments	Download
M	tools/dom/src/native_DOMPublic.dart	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsm

7 years, 3 months ago (2013-09-17 17:27:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27577 (presubmit successful).

Expand Messages | Collapse Messages