Added polyfill for var (moved from web_ui)

Include tests for polyfill and without polyfill

BUG=
R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27320

[Siggi Cherem (dart-lang), 2013-09-09 19:53:38]

https://codereview.chromium.org/23868008/diff/1/pkg/csslib/lib/src/polyfill.dart
File pkg/csslib/lib/src/polyfill.dart (right):

https://codereview.chromium.org/23868008/diff/1/pkg/csslib/lib/src/polyfill.d...
pkg/csslib/lib/src/polyfill.dart:63: for (var tree in styleSheets) new
_ResolveVarUsages(varDefs).visitTree(tree);
style: 80 col and add { } (we only skip them for fast-exit if statements)

https://codereview.chromium.org/23868008/diff/1/pkg/csslib/lib/src/polyfill.d...
pkg/csslib/lib/src/polyfill.dart:214: VarDefinition varDef) {
fix indentation: missing a space, or only indent +4?

(both are allowed, but I normally prefer the +4 indent because it is easier to
maintain)

https://codereview.chromium.org/23868008/diff/1/pkg/csslib/test/var_test.dart
File pkg/csslib/test/var_test.dart (right):

https://codereview.chromium.org/23868008/diff/1/pkg/csslib/test/var_test.dart...
pkg/csslib/test/var_test.dart:642: opts: ['--no-colors', 'memory'], polyfill:
true);
should we also test the other features like var(a), calc, etc?

[terry, 2013-09-09 20:04:50]

PTAL

https://codereview.chromium.org/23868008/diff/1/pkg/csslib/lib/src/polyfill.dart
File pkg/csslib/lib/src/polyfill.dart (right):

https://codereview.chromium.org/23868008/diff/1/pkg/csslib/lib/src/polyfill.d...
pkg/csslib/lib/src/polyfill.dart:63: for (var tree in styleSheets) new
_ResolveVarUsages(varDefs).visitTree(tree);
On 2013/09/09 19:53:38, Siggi Cherem (dart-lang) wrote:
> style: 80 col and add { } (we only skip them for fast-exit if statements)

Done.

https://codereview.chromium.org/23868008/diff/1/pkg/csslib/lib/src/polyfill.d...
pkg/csslib/lib/src/polyfill.dart:214: VarDefinition varDef) {
On 2013/09/09 19:53:38, Siggi Cherem (dart-lang) wrote:
> fix indentation: missing a space, or only indent +4?
> 
> (both are allowed, but I normally prefer the +4 indent because it is easier to
> maintain)

+4 Done.

https://codereview.chromium.org/23868008/diff/1/pkg/csslib/test/var_test.dart
File pkg/csslib/test/var_test.dart (right):

https://codereview.chromium.org/23868008/diff/1/pkg/csslib/test/var_test.dart...
pkg/csslib/test/var_test.dart:642: opts: ['--no-colors', 'memory'], polyfill:
true);
Yes, I will however "@foo: red;" and "var-foo; red;" generate same AST as does
@foo or var(foo) in a property.  I will expand these test quite a bit when I
have dependencies working and I'll move over the full blown testing I did for
var in web_ui for these.

On 2013/09/09 19:53:38, Siggi Cherem (dart-lang) wrote:
> should we also test the other features like var(a), calc, etc?

[Siggi Cherem (dart-lang), 2013-09-09 20:16:39]

lgtm

[terry, 2013-09-09 23:16:19]

Committed patchset #3 manually as r27320 (presubmit successful).