Issue 23868006: Change language/number_identifier_test to be correct.

Issue 23868006: Change language/number_identifier_test to be correct. (Closed)

Created:
7 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 3 months ago

Reviewers:
ahe, hausner

CC:
reviews_dartlang.org, Søren Gjesse, gbracha

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change language/number_identifier_test to be correct. Also make it more comprehensive. BUG: http://dartbug.com/13014 http://dartbug.com/13015 R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=27187

Patch Set 1 #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -12 lines)			Patch
M	tests/language/language.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	tests/language/number_identifier_test.dart	View	1 chunk	+31 lines, -2 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Committed patchset #1 manually as r27187 (presubmit successful).

7 years, 3 months ago (2013-09-05 10:28:43 UTC) #3

hausner

https://codereview.chromium.org/23868006/diff/1/tests/language/number_identifier_test.dart File tests/language/number_identifier_test.dart (right): https://codereview.chromium.org/23868006/diff/1/tests/language/number_identifier_test.dart#newcode34 tests/language/number_identifier_test.dart:34: e.memberName == const Symbol("e")); /// 05: continued NoSuchMethodError does ...

7 years, 3 months ago (2013-09-05 20:10:24 UTC) #4

ahe

7 years, 3 months ago (2013-09-05 20:12:27 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/23868006/diff/1/tests/language/number_identif...
File tests/language/number_identifier_test.dart (right):

https://codereview.chromium.org/23868006/diff/1/tests/language/number_identif...
tests/language/number_identifier_test.dart:34: e.memberName == const
Symbol("e"));   /// 05: continued
On 2013/09/05 20:10:24, hausner wrote:
> NoSuchMethodError does not have an accessor called memberName. I am fixing the
> test as part of another checkin.

Good catch, thank you for fixing it!

Expand Messages | Collapse Messages