Issue 238503003: Make [Barback.getAllAssets] work when called synchronously.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 238503003: Make [Barback.getAllAssets] work when called synchronously. (Closed)

Created:
6 years, 8 months ago by nweiz

Modified:
6 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make [Barback.getAllAssets] work when called synchronously. This was broken because InputNode didn't take its input being dirty into account when calculating whether it was dirty, so the synchronous period between providing Barback with assets and getting those assets' values had the graph marked as clean but none of its outputs yet available. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=35098

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -31 lines)			Patch
M	pkg/barback/lib/src/phase_input.dart	View	3 chunks	+13 lines, -2 lines	0 comments	Download
M	pkg/barback/test/package_graph/get_all_assets_test.dart	View	2 chunks	+23 lines, -0 lines	0 comments	Download
M	pkg/barback/test/utils.dart	View	3 chunks	+33 lines, -29 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

6 years, 8 months ago (2014-04-15 23:54:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35098 (presubmit successful).

Expand Messages | Collapse Messages