- Use simplified token location call where appropriate.

- Use simplified token location call where appropriate.

R=asiva@google.com, hausner@google.com, mlippautz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27833

[siva, 2013-09-24 00:09:29]

lgtm

[hausner, 2013-09-24 00:11:56]

LGTM

[Michael Lippautz (Google), 2013-09-24 00:16:16]

lgtm :)

[Ivan Posva, 2013-09-24 17:28:01]

Bob: FYI

-Ivan

[Ivan Posva, 2013-09-24 17:32:44]

Committed patchset #3 manually as r27833 (presubmit successful).

[Bob Nystrom, 2013-09-24 17:53:56]

Adding Nathan to review it.

https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/lib/src/f...
File pkg/stack_trace/lib/src/frame.dart (right):

https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/lib/src/f...
pkg/stack_trace/lib/src/frame.dart:117: var col = null;
"col" -> "column".

https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/lib/src/f...
pkg/stack_trace/lib/src/frame.dart:118: var col_match = match[4];
"col_match" -> "columnMatch".

[nweiz, 2013-09-24 20:16:03]

Please don't commit CLs that modify code you don't own without getting an LGTM
from the owner first.

https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/lib/src/f...
File pkg/stack_trace/lib/src/frame.dart (right):

https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/lib/src/f...
pkg/stack_trace/lib/src/frame.dart:118: var col_match = match[4];
On 2013/09/24 17:53:56, Bob Nystrom wrote:
> "col_match" -> "columnMatch".

This variable seems superfluous. Just use match[4] instead.

https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/test/fram...
File pkg/stack_trace/test/frame_test.dart (right):

https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/test/fram...
pkg/stack_trace/test/frame_test.dart:51: });
Add a test that validates the new format that is now being parsed.

[Ivan Posva, 2013-09-24 20:55:11]

Fixed in r27852.

-Ivan

https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/lib/src/f...
File pkg/stack_trace/lib/src/frame.dart (right):

https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/lib/src/f...
pkg/stack_trace/lib/src/frame.dart:117: var col = null;
On 2013/09/24 17:53:56, Bob Nystrom wrote:
> "col" -> "column".

Done.

https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/lib/src/f...
pkg/stack_trace/lib/src/frame.dart:118: var col_match = match[4];
On 2013/09/24 17:53:56, Bob Nystrom wrote:
> "col_match" -> "columnMatch".

Done.

https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/lib/src/f...
pkg/stack_trace/lib/src/frame.dart:118: var col_match = match[4];
On 2013/09/24 20:16:03, nweiz wrote:
> On 2013/09/24 17:53:56, Bob Nystrom wrote:
> > "col_match" -> "columnMatch".
> 
> This variable seems superfluous. Just use match[4] instead.

Every time you access that same array element, you duplicate more strings for no
reason.

https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/test/fram...
File pkg/stack_trace/test/frame_test.dart (right):

https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/test/fram...
pkg/stack_trace/test/frame_test.dart:51: });
On 2013/09/24 20:16:03, nweiz wrote:
> Add a test that validates the new format that is now being parsed.

Done.

[nweiz, 2013-09-24 20:57:11]

https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/lib/src/f...
File pkg/stack_trace/lib/src/frame.dart (right):

https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/lib/src/f...
pkg/stack_trace/lib/src/frame.dart:118: var col_match = match[4];
On 2013/09/24 20:55:11, Ivan Posva wrote:
> On 2013/09/24 20:16:03, nweiz wrote:
> > On 2013/09/24 17:53:56, Bob Nystrom wrote:
> > > "col_match" -> "columnMatch".
> > 
> > This variable seems superfluous. Just use match[4] instead.
> 
> Every time you access that same array element, you duplicate more strings for
no
> reason.

I care about that a couple orders of magnitude less than I care about code
cleanliness.

[Ivan Posva, 2013-09-24 21:11:57]

On 2013/09/24 20:57:11, nweiz wrote:
>
https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/lib/src/f...
> File pkg/stack_trace/lib/src/frame.dart (right):
> 
>
https://codereview.chromium.org/23850014/diff/12001/pkg/stack_trace/lib/src/f...
> pkg/stack_trace/lib/src/frame.dart:118: var col_match = match[4];
> On 2013/09/24 20:55:11, Ivan Posva wrote:
> > On 2013/09/24 20:16:03, nweiz wrote:
> > > On 2013/09/24 17:53:56, Bob Nystrom wrote:
> > > > "col_match" -> "columnMatch".
> > > 
> > > This variable seems superfluous. Just use match[4] instead.
> > 
> > Every time you access that same array element, you duplicate more strings
for
> no
> > reason.
> 
> I care about that a couple orders of magnitude less than I care about code
> cleanliness.

I can definitely see that repeated uses of "match[4]" are more descriptive and
cleaner than "columnMatch".

-Ivan