Issue 238443002: Rename BuildDirectory -> SourceDirectory.

Issue 238443002: Rename BuildDirectory -> SourceDirectory. (Closed)

Created:
6 years, 8 months ago by Bob Nystrom

Modified:
6 years, 8 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename BuildDirectory -> SourceDirectory. Also a few related clean-ups and renames. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=35114

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -882 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback/admin_server.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
A +	sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart	View	11 chunks	+26 lines, -41 lines	2 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/barback_server.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/base_server.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	sdk/lib/_internal/pub/lib/src/barback/build_directory.dart	View	1 chunk	+0 lines, -70 lines	0 comments	Download
D	sdk/lib/_internal/pub/lib/src/barback/build_environment.dart	View	1 chunk	+0 lines, -733 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart	View	7 chunks	+7 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart	View	1 chunk	+2 lines, -4 lines	0 comments	Download
A +	sdk/lib/_internal/pub/lib/src/barback/source_directory.dart	View	3 chunks	+6 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command/build.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command/serve.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/238443002/diff/1/sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart File sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart (right): https://codereview.chromium.org/238443002/diff/1/sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart#newcode77 sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart:77: /// build environment, keyed by their root directory. ...

6 years, 8 months ago (2014-04-15 01:22:47 UTC) #2

Bob Nystrom

Committed patchset #1 manually as r35114 (presubmit successful).

6 years, 8 months ago (2014-04-16 17:23:46 UTC) #3

Bob Nystrom

6 years, 8 months ago (2014-04-16 17:24:10 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/238443002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart (right):

https://codereview.chromium.org/238443002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart:77: /// build
environment, keyed by their root directory.
On 2014/04/15 01:22:47, nweiz wrote:
> "available part of the build environment" -> "part of the asset environment"

Done.

Expand Messages | Collapse Messages