Increase timeout of some pub tests.

Increase timeout of some pub tests.

Committed: https://code.google.com/p/dart/source/detail?r=26976

[ahe, 2013-08-31 11:19:49]

In CL 22849010, I implemented a timeout of 20 seconds on test cases. This makes
it easier to discover which subtest is broken.

After submitting this change, two pub tests timed out. This CL increases the
timeout of those two tests.

[ahe, 2013-08-31 11:20:10]

Submitting TBR to fix the pub build bot.

[ahe, 2013-08-31 11:20:40]

Committed patchset #1 manually as r26976 (presubmit successful).

[Bill Hesse, 2013-09-02 14:52:53]

There are more pub tests than these two that need their timeouts increased. 
Looking at the time results from a run of pub on the Windows buildbot shows 5 or
6 tests taking between 10 and 20 seconds, and one of them is now flaking:
dartbug.com/12983
dartbug.com/12984

[ahe, 2013-09-02 18:48:57]

On 2013/09/02 14:52:53, Bill Hesse wrote:
> There are more pub tests than these two that need their timeouts increased. 
> Looking at the time results from a run of pub on the Windows buildbot shows 5
or
> 6 tests taking between 10 and 20 seconds, and one of them is now flaking:
> dartbug.com/12983
> dartbug.com/12984

Just because a test runs for 10 to 20 seconds, it might not timeout.

It is only pub integration tests which have only one unittest subtest that will
be affected. I think I'll revert this CL and update
sdk/lib/_internal/pub/test/pub_test.dart to alway use a 60 second timeout.

[nweiz, 2013-09-03 18:29:41]

In general, I don't think that just increasing the timeout is going to be a
sustainable solution for these tests. They're unreasonably slow on the bots, and
getting slower. I think we need to work with the people who maintain the
buildbots to find the root cause of this sluggishness and fix that.

https://codereview.chromium.org/23844002/diff/1/dart/sdk/lib/_internal/pub/te...
File
dart/sdk/lib/_internal/pub/test/update/git/do_not_update_if_unneeded_test.dart
(right):

https://codereview.chromium.org/23844002/diff/1/dart/sdk/lib/_internal/pub/te...
dart/sdk/lib/_internal/pub/test/update/git/do_not_update_if_unneeded_test.dart:13:
unittestConfiguration.timeout = const Duration(seconds: 60);
Rather than setting the timeout to a larger constant, multiply it by some
factor. That ensures that multiple adjustments to the timeout work together
rather than just being "last wins".

Also, where is this [timeout] field defined? I don't see it anywhere in
pkg/unittest.

[ahe, 2013-09-03 18:55:15]

On 2013/09/03 18:29:41, nweiz wrote:
> In general, I don't think that just increasing the timeout is going to be a
> sustainable solution for these tests. They're unreasonably slow on the bots,
and
> getting slower. I think we need to work with the people who maintain the
> buildbots to find the root cause of this sluggishness and fix that.

I have disabled the timeout for all pub integration tests with
https://code.google.com/p/dart/source/detail?r=27031

You can contact ricow@ and kustermann@ about help with sluggishness on the build
bot.

>
https://codereview.chromium.org/23844002/diff/1/dart/sdk/lib/_internal/pub/te...
> File
> dart/sdk/lib/_internal/pub/test/update/git/do_not_update_if_unneeded_test.dart
> (right):
> 
>
https://codereview.chromium.org/23844002/diff/1/dart/sdk/lib/_internal/pub/te...
>
dart/sdk/lib/_internal/pub/test/update/git/do_not_update_if_unneeded_test.dart:13:
> unittestConfiguration.timeout = const Duration(seconds: 60);
> Rather than setting the timeout to a larger constant, multiply it by some
> factor. That ensures that multiple adjustments to the timeout work together
> rather than just being "last wins".
> 
> Also, where is this [timeout] field defined? I don't see it anywhere in
> pkg/unittest.

Perhaps you're looking at an older version, I only added the timeout field over
the weekend, see:

https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/pkg/...

Cheers,
Peter