Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2383943002: enable parse test now that dart2js generates correct format (Closed)

Created:
4 years, 2 months ago by Harry Terkelsen
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

enable parse test now that dart2js generates correct format R=sigmund@google.com Committed: https://github.com/dart-lang/dart2js_info/commit/8c4b4f60b9d8ea16ace894003f2dfd0a6b704c0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M test/hello_world/hello_world.js.info.json View 1 chunk +6 lines, -6 lines 0 comments Download
M test/parse_test.dart View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 2 months ago (2016-09-30 23:20:05 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 2 months ago (2016-09-30 23:22:09 UTC) #3
Harry Terkelsen
4 years, 2 months ago (2016-09-30 23:24:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c4b4f60b9d8ea16ace894003f2dfd0a6b704c0d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698