Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 238293006: Create analysis server ByteStreamServerChannel class. (Closed)

Created:
6 years, 8 months ago by Paul Berry
Modified:
6 years, 8 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Create analysis server ByteStreamServerChannel class. This class serves a parallel role to the existing WebSocketServerChannel interface, except that it handles exchanging data with stdio rather than with a WebSocket. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=35088

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -1 line) Patch
M pkg/analysis_server/lib/src/channel.dart View 1 chunk +45 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/channel_test.dart View 3 chunks +137 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 8 months ago (2014-04-15 21:03:18 UTC) #1
Brian Wilkerson
LGTM
6 years, 8 months ago (2014-04-15 21:32:13 UTC) #2
Paul Berry
6 years, 8 months ago (2014-04-15 21:43:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35088 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698