Issue 23829002: Checkpoint in changes to match push

Issue 23829002: Checkpoint in changes to match push (Closed)

Created:
7 years, 3 months ago by Jacob

Modified:
7 years, 3 months ago

Reviewers:
blois

CC:
reviews_dartlang.org, vsm

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Dart binding changes to along with Blink merge 155942-156717 BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=26948

Patch Set 1 : Ready for review #

Total comments: 4

Patch Set 3 : We were missing onReadyStateChange #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1233 lines, -886 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		35 chunks	+414 lines, -296 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		37 chunks	+486 lines, -389 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View		9 chunks	+9 lines, -9 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View		3 chunks	+27 lines, -117 lines	0 comments	Download
M	tests/html/html.status	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/html/wheelevent_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/dom.json	View	1	14 chunks	+239 lines, -29 lines	0 comments	Download
M	tools/dom/idl/dart/dart.idl	View		4 chunks	+7 lines, -11 lines	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	tools/dom/scripts/htmleventgenerator.py	View	1 2	2 chunks	+13 lines, -19 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/scripts/systemnative.py	View		4 chunks	+15 lines, -1 line	0 comments	Download
M	tools/dom/src/CrossFrameTypes.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_WheelEvent.darttemplate	View		4 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

lgtm, some tweaks which will prevent breaking some stuff. https://codereview.chromium.org/23829002/diff/3001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (right): https://codereview.chromium.org/23829002/diff/3001/sdk/lib/html/dartium/html_dartium.dart#newcode28145 sdk/lib/html/dartium/html_dartium.dart:28145: ...

7 years, 3 months ago (2013-08-30 20:15:19 UTC) #2

Jacob

https://codereview.chromium.org/23829002/diff/3001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (right): https://codereview.chromium.org/23829002/diff/3001/sdk/lib/html/dartium/html_dartium.dart#newcode28145 sdk/lib/html/dartium/html_dartium.dart:28145: + static const EventStreamProvider<Event> abortEvent = const EventStreamProvider<Event>('abort'); On ...

7 years, 3 months ago (2013-08-30 20:27:15 UTC) #3

Jacob

7 years, 3 months ago (2013-08-30 21:24:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r26948 (presubmit successful).

Expand Messages | Collapse Messages