Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 23828006: One-liners for unittest and matcher (Closed)

Created:
7 years, 3 months ago by Kathy Walrath
Modified:
7 years, 3 months ago
Reviewers:
gram, mem
CC:
reviews_dartlang.org
Visibility:
Public.

Description

One-liners for unittest and matcher. Also had to give a one-liner to stack_trace, to work around a doc generation issue (dartbug.com/13246). R=gram@google.com Committed: https://code.google.com/p/dart/source/detail?r=27398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -39 lines) Patch
M pkg/stack_trace/lib/stack_trace.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/unittest/lib/matcher.dart View 1 chunk +11 lines, -18 lines 0 comments Download
M pkg/unittest/lib/unittest.dart View 2 chunks +13 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kathy Walrath
7 years, 3 months ago (2013-09-11 18:20:58 UTC) #1
gram
lgtm
7 years, 3 months ago (2013-09-11 19:01:03 UTC) #2
Kathy Walrath
7 years, 3 months ago (2013-09-11 19:28:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27398 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698