Issue 23817006: Dartium custom element lifecycle event support.

Issue 23817006: Dartium custom element lifecycle event support. (Closed)

Created:
7 years, 3 months ago by blois

Modified:
7 years, 3 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Start of dartium custom element lifecycle event support. These are the Dart repo changes paired with https://codereview.chromium.org/24294002/ BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=27718

Patch Set 3 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -83 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		10 chunks	+35 lines, -41 lines	0 comments	Download
M	tests/html/custom/document_register_type_extensions_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/dom/idl/dart/dart.idl	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	1 2	3 chunks	+8 lines, -0 lines	0 comments	Download
M	tools/dom/src/native_DOMImplementation.dart	View	1 2	6 chunks	+23 lines, -34 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://codereview.chromium.org/23817006/diff/3001/tests/html/custom/document_register_type_extensions_test.dart File tests/html/custom/document_register_type_extensions_test.dart (right): https://codereview.chromium.org/23817006/diff/3001/tests/html/custom/document_register_type_extensions_test.dart#newcode75 tests/html/custom/document_register_type_extensions_test.dart:75: document.register(Bar.tag, Bar, extendsTag: 'input'); maybe just 'extends' for ...

7 years, 3 months ago (2013-09-19 23:16:32 UTC) #2

blois

https://codereview.chromium.org/23817006/diff/3001/tests/html/custom/document_register_type_extensions_test.dart File tests/html/custom/document_register_type_extensions_test.dart (right): https://codereview.chromium.org/23817006/diff/3001/tests/html/custom/document_register_type_extensions_test.dart#newcode75 tests/html/custom/document_register_type_extensions_test.dart:75: document.register(Bar.tag, Bar, extendsTag: 'input'); On 2013/09/19 23:16:32, vsm wrote: ...

7 years, 3 months ago (2013-09-20 00:05:04 UTC) #3

blois

7 years, 3 months ago (2013-09-20 18:40:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r27718 (presubmit successful).

Expand Messages | Collapse Messages