Issue 23816004: Is checks on the right hand side of an || used in an 'if' do not apply to the then branch of that i…

Issue 23816004: Is checks on the right hand side of an || used in an 'if' do not apply to the then branch of that i… (Closed)

Created:
7 years, 3 months ago by ngeoffray

Modified:
7 years, 3 months ago

Reviewers:
Johnni Winther, Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Is checks on the right hand side of an || used in an 'if' do not apply to the then branch of that if. R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=27177

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	tests/compiler/dart2js/simple_inferrer_test.dart	View	1	3 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

LGTM. If the tests failed before and they succeed now, then I trust the code ...

7 years, 3 months ago (2013-09-05 07:17:46 UTC) #2

ngeoffray

Thanks Lasse. https://codereview.chromium.org/23816004/diff/3001/tests/compiler/dart2js/simple_inferrer_test.dart File tests/compiler/dart2js/simple_inferrer_test.dart (right): https://codereview.chromium.org/23816004/diff/3001/tests/compiler/dart2js/simple_inferrer_test.dart#newcode246 tests/compiler/dart2js/simple_inferrer_test.dart:246: return a is int || a is ...

7 years, 3 months ago (2013-09-05 07:33:57 UTC) #3

ngeoffray

7 years, 3 months ago (2013-09-05 07:34:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r27177 (presubmit successful).

Expand Messages | Collapse Messages