Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 23810003: Make showHide combinators work with getter/setter names (Closed)

Created:
7 years, 3 months ago by hausner
Modified:
7 years, 3 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org, nweiz
Visibility:
Public.

Description

Make showHide combinators work with getter/setter names Adding test language/import_show_test.dart Fixes issue 9535 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=27136

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M runtime/vm/object.cc View 3 chunks +13 lines, -2 lines 0 comments Download
A tests/language/import_show_lib.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A tests/language/import_show_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
7 years, 3 months ago (2013-09-04 17:39:28 UTC) #1
regis
LGTM
7 years, 3 months ago (2013-09-04 17:54:31 UTC) #2
hausner
7 years, 3 months ago (2013-09-04 18:00:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r27136 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698