Issue 23809011: Fix language/duplicate_implements_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23809011: Fix language/duplicate_implements_test. (Closed)

Created:
7 years, 3 months ago by karlklose

Modified:
7 years, 3 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix language/duplicate_implements_test. Previously, tree shaking would no look at the implements clauses, because the classes are never analyzed. BUG=dartbug.com/12991 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=27429

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -9 lines)			Patch
	M	tests/language/duplicate_implements_test.dart	View		1 chunk	+4 lines, -1 line	1 comment	Download
	M	tests/language/language_dart2js.status	View		2 chunks	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://codereview.chromium.org/23809011/diff/1/tests/language/duplicate_implements_test.dart File tests/language/duplicate_implements_test.dart (right): https://codereview.chromium.org/23809011/diff/1/tests/language/duplicate_implements_test.dart#newcode3 tests/language/duplicate_implements_test.dart:3: // BSD-style license that can be found in ...

7 years, 3 months ago (2013-09-12 09:23:08 UTC) #2

karlklose

7 years, 3 months ago (2013-09-12 12:10:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27429 (presubmit successful).

Expand Messages | Collapse Messages