Don't time out when uploading a package for "pub lish".

Don't time out when uploading a package for "pub lish".

R=rnystrom@google.com
BUG=18180
Committed: https://code.google.com/p/dart/source/detail?r=35085

[Bob Nystrom, 2014-04-15 00:11:02]

Did you check to see how a timeout from the underlying dart:io HTTP gets handled
by pub?

https://codereview.chromium.org/238083002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/lish.dart (right):

https://codereview.chromium.org/238083002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/lish.dart:59:
request.headers['Pub-Http-Timeout'] = 'None';
Is there a reason you added this to the headers instead of doing something like
making it a named param to .send()? Is this a Shelf convention thing?

[nweiz, 2014-04-15 01:02:29]

It turns out dart:io just doesn't have an underlying time out. It'll let a
request dangle arbitrarily long. This makes some sense, since it enables things
like Comet.

https://codereview.chromium.org/238083002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/lish.dart (right):

https://codereview.chromium.org/238083002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/lish.dart:59:
request.headers['Pub-Http-Timeout'] = 'None';
On 2014/04/15 00:11:02, Bob Nystrom wrote:
> Is there a reason you added this to the headers instead of doing something
like
> making it a named param to .send()?

[client] here is actually an oauth2.Client, not a PubHttpClient, so we can't add
extra behavior via [send].

> Is this a Shelf convention thing?

The Shelf-y way of doing this would be to use the "context" map rather than a
header, but that doesn't exist in the HTTP package yet. At some point when
shelf's API is more stable, I want to do a big HTTP rework that will make it
more shelfy, but that time is not here yet.

[Bob Nystrom, 2014-04-15 18:34:00]

lgtm

[nweiz, 2014-04-15 21:23:15]

Committed patchset #1 manually as r35085 (presubmit successful).