Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 237963009: Remove redundant initialization of HttpAnalysisServer.socketServer. (Closed)

Created:
6 years, 8 months ago by Paul Berry
Modified:
6 years, 8 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove redundant initialization of HttpAnalysisServer.socketServer. This was mistakenly left out of r35075. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=35089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analysis_server/lib/http_server.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 8 months ago (2014-04-15 21:14:44 UTC) #1
Brian Wilkerson
LGTM
6 years, 8 months ago (2014-04-15 21:33:09 UTC) #2
Paul Berry
6 years, 8 months ago (2014-04-15 21:45:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35089 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698