Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 23788012: Fix an off-by-one error in deoptimization compression. (Closed)

Created:
7 years, 3 months ago by Kevin Millikin (Google)
Modified:
7 years, 3 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix an off-by-one error in deoptimization compression. When compressing the deoptimization info, suffixes of length one are not shared (the compression is the same length as the original, but more indirect). However, they were grafted onto the trie as if they were shared, i.e., one level lower than they should be. Add debug code to verify the compression/decompression round trip. BUG=dartbug.com/13273 R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=27602

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added changes to all platform files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -13 lines) Patch
M runtime/vm/deopt_instructions.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/deopt_instructions.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
https://codereview.chromium.org/23788012/diff/1/runtime/vm/deopt_instructions.h File runtime/vm/deopt_instructions.h (right): https://codereview.chromium.org/23788012/diff/1/runtime/vm/deopt_instructions.h#newcode205 runtime/vm/deopt_instructions.h:205: RawDeoptInfo* CreateDeoptInfo(const Array& deopt_table); The table gets threaded around ...
7 years, 3 months ago (2013-09-13 13:46:17 UTC) #1
Florian Schneider
lgtm
7 years, 3 months ago (2013-09-16 08:08:58 UTC) #2
Kevin Millikin (Google)
7 years, 3 months ago (2013-09-18 10:16:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r27602 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698