Issue 23788009: Allows build of the standalone VM for ARM adroid.

Issue 23788009: Allows build of the standalone VM for ARM adroid. (Closed)

Created:
7 years, 3 months ago by zra

Modified:
7 years, 3 months ago

Reviewers:
vsm, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Allows build of the standalone VM for ARM adroid. R=iposva@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=27506

Patch Set 5 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -14 lines)			Patch
runtime/vm/assembler_arm.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
tools/build.py	View	1 2 3 4	6 chunks	+26 lines, -10 lines	0 comments	Download
tools/gyp/all.gypi	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
tools/gyp/common.gypi	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
tools/gyp/configurations_android.gypi	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

zra

This allows you to build with: ./tools/build.py -m release -a arm --os=android runtime Then you ...

7 years, 3 months ago (2013-09-06 22:30:35 UTC) #1

vsm

lgtm https://codereview.chromium.org/23788009/diff/5001/tools/build.py File tools/build.py (right): https://codereview.chromium.org/23788009/diff/5001/tools/build.py#newcode428 tools/build.py:428: if target_os == 'android' and arch == 'ia32': ...

7 years, 3 months ago (2013-09-06 23:25:30 UTC) #2

Ivan Posva

LGTMwC -Ivan https://codereview.chromium.org/23788009/diff/10001/tools/gyp/configurations_android.gypi File tools/gyp/configurations_android.gypi (right): https://codereview.chromium.org/23788009/diff/10001/tools/gyp/configurations_android.gypi#newcode36 tools/gyp/configurations_android.gypi:36: 'android_target_arch%' : 'x86', Shouldn't we set the ...

7 years, 3 months ago (2013-09-13 22:08:38 UTC) #3

zra

Thanks! https://codereview.chromium.org/23788009/diff/5001/tools/build.py File tools/build.py (right): https://codereview.chromium.org/23788009/diff/5001/tools/build.py#newcode428 tools/build.py:428: if target_os == 'android' and arch == 'ia32': ...

7 years, 3 months ago (2013-09-13 23:28:45 UTC) #4

zra

7 years, 3 months ago (2013-09-13 23:29:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r27506 (presubmit successful).

Expand Messages | Collapse Messages