pkg/docgen: add --indent-json option

pkg/docgen: add --indent-json option

R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35054

[kevmoo, 2014-04-14 21:37:49]

https://codereview.chromium.org/237863002/diff/1/pkg/docgen/lib/src/generator...
File pkg/docgen/lib/src/generator.dart (left):

https://codereview.chromium.org/237863002/diff/1/pkg/docgen/lib/src/generator...
pkg/docgen/lib/src/generator.dart:137: Directory dir = new
Directory(_outputDirectory);
This was a whole mountain of silly.

https://codereview.chromium.org/237863002/diff/1/pkg/docgen/lib/src/generator...
File pkg/docgen/lib/src/generator.dart (right):

https://codereview.chromium.org/237863002/diff/1/pkg/docgen/lib/src/generator...
pkg/docgen/lib/src/generator.dart:236: var buffer = new StringBuffer()
Avoid creating a huge string, then another one just to add the new line char at
the end

https://codereview.chromium.org/237863002/diff/1/pkg/docgen/test/generate_jso...
File pkg/docgen/test/generate_json_test.dart (right):

https://codereview.chromium.org/237863002/diff/1/pkg/docgen/test/generate_jso...
pkg/docgen/test/generate_json_test.dart:34:
startsWith(_LIBRARY_LIST_UNINDENT_START)),
Checking that the default is to still generate a "flat" JSON output

[Emily Fortuna, 2014-04-14 23:40:32]

lgtm

https://codereview.chromium.org/237863002/diff/1/pkg/docgen/lib/src/generator...
File pkg/docgen/lib/src/generator.dart (left):

https://codereview.chromium.org/237863002/diff/1/pkg/docgen/lib/src/generator...
pkg/docgen/lib/src/generator.dart:137: Directory dir = new
Directory(_outputDirectory);
On 2014/04/14 21:37:49, kevmoo wrote:
> This was a whole mountain of silly.

oy vey. thank you.

https://codereview.chromium.org/237863002/diff/1/pkg/docgen/lib/src/generator...
File pkg/docgen/lib/src/generator.dart (right):

https://codereview.chromium.org/237863002/diff/1/pkg/docgen/lib/src/generator...
pkg/docgen/lib/src/generator.dart:236: var buffer = new StringBuffer()
On 2014/04/14 21:37:49, kevmoo wrote:
> Avoid creating a huge string, then another one just to add the new line char
at
> the end

sgtm

[kevmoo, 2014-04-15 00:13:28]

Committed patchset #1 manually as r35054 (presubmit successful).