Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 23769002: Fix build for pub after new analyzer_experimental snapshot. (Closed)

Created:
7 years, 3 months ago by scheglov
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix build for pub after new analyzer_experimental snapshot. R=brianwilkerson@google.com, jmesserly@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M pkg/observe/lib/transform.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
7 years, 3 months ago (2013-08-29 16:53:47 UTC) #1
Bob Nystrom
On 2013/08/29 16:53:47, scheglov wrote: The pub bots also run all of the pkg tests, ...
7 years, 3 months ago (2013-08-29 16:58:57 UTC) #2
Brian Wilkerson
LGTM, but I don't understand the context, so...
7 years, 3 months ago (2013-08-29 17:09:40 UTC) #3
Jennifer Messerly
On 2013/08/29 17:09:40, Brian Wilkerson wrote: > LGTM, but I don't understand the context, so... ...
7 years, 3 months ago (2013-08-29 17:10:39 UTC) #4
scheglov
7 years, 3 months ago (2013-08-29 17:22:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r26883 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698