Disable applyAuthorStyles

Disable applyAuthorStyles

This allows us to remove the dependency on bootstrap.css (removal of bootstrap.css from third_party will happen in follow up CL).

As a side effect of this, the following changes have occurred:

- Removed Google Charts Table from allocation profile pane.
- Add a SortedTable view-model (used in allocation profile).
- Changes to CPU profile tree view.
- Consolidate string formatting utility functions.

There is some UI regression (font size is one size too small) that will have to be addressed in follow up CLs.

[turnidge, 2014-04-17 20:18:54]

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/app/view_model.dart (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/app/view_model.dart:106: static String
toStringFormatter(dynamic v) => v != null ? v.toString() : '<null>';
Line is long.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/app/view_model.dart:122: final List<int>
_order = [];
name - maybe _sortedRows?

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/app/view_model.dart:124:
SortedTable(this.columns) {
drop constructor body -> SortedTable(this.columns);

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/app/view_model.dart:177: const none = '';
Is 'none' used?

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/app/view_model.dart:190: String row = '';
Does it make sense to use StringBuffer here?

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/css/shared.css (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/css/shared.css:128: .well {
Is this "falling down a well" or "thank you, I feel well"?

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/error_view.html (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/error_view.html:15: </div>
We should probably just use the .content style here that we use on our browse
pages.  That will keep the padding consistent.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/heap_profile.dart (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/heap_profile.dart:58:
classTable.sortColumnIndex = 1;
This code seems a lot simpler now.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/heap_profile.html (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/heap_profile.html:20: .table tfoot
> tr > td {
Since we are in a custom element, do we need this level of specificity?  Would
it work to just have:

th, td {
...
}

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart:22:
@reflectable String tipTime = '';
Is the popup tip something that should be in a custom element?  Just asking.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart:169: const
colors = const ['color0', 'color1', 'color2', 'color4', 'color5',
What happened to color3? 

We should probably name these styles something more specific... maybe rowColor0,
rowColor1... dunno.

Also, if the numbers were known dense, you could avoid the lookup array:

const int maxColor = X;
var d = row.depth - 1;
return "rowColor${d % maxColor}";

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/nav_bar.html (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/nav_bar.html:51: top: 98%;
I wonder how this will look on mac.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/service_error_view.html
(right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/service_error_view.html:14: </div>
ditto comment on using the ".content" class from our browse pages.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/service_exception_view.html
(right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/service_exception_view.html:14:
</div>
ditto ditto

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/stack_trace.html (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/stack_trace.html:13: }
We should consider moving these styles up to the shared sheet.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/vm_view.html (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/vm_view.html:67: <br>
Did you get <br>'s to look nice yet?

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/web/css/shared.css (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/web/css/shared.css:1:
../../lib/src/elements/css/shared.css
What's this about?

[Cutch, 2014-04-17 22:12:38]

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/app/view_model.dart (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/app/view_model.dart:106: static String
toStringFormatter(dynamic v) => v != null ? v.toString() : '<null>';
On 2014/04/17 20:18:54, turnidge wrote:
> Line is long.

Done.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/app/view_model.dart:122: final List<int>
_order = [];
On 2014/04/17 20:18:54, turnidge wrote:
> name - maybe _sortedRows?

Done.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/app/view_model.dart:122: final List<int>
_order = [];
On 2014/04/17 20:18:54, turnidge wrote:
> name - maybe _sortedRows?

Done.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/app/view_model.dart:124:
SortedTable(this.columns) {
On 2014/04/17 20:18:54, turnidge wrote:
> drop constructor body -> SortedTable(this.columns);

Done.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/app/view_model.dart:177: const none = '';
On 2014/04/17 20:18:54, turnidge wrote:
> Is 'none' used?

Dead.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/app/view_model.dart:190: String row = '';
On 2014/04/17 20:18:54, turnidge wrote:
> Does it make sense to use StringBuffer here?

This code was only used for debugging. Removed.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/css/shared.css (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/css/shared.css:128: .well {
On 2014/04/17 20:18:54, turnidge wrote:
> Is this "falling down a well" or "thank you, I feel well"?

http://getbootstrap.com/components/#wells

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/error_view.html (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/error_view.html:15: </div>
On 2014/04/17 20:18:54, turnidge wrote:
> We should probably just use the .content style here that we use on our browse
> pages.  That will keep the padding consistent.

Done.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/heap_profile.dart (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/heap_profile.dart:58:
classTable.sortColumnIndex = 1;
On 2014/04/17 20:18:54, turnidge wrote:
> This code seems a lot simpler now.

Done.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/heap_profile.html (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/heap_profile.html:20: .table tfoot
> tr > td {
On 2014/04/17 20:18:54, turnidge wrote:
> Since we are in a custom element, do we need this level of specificity?  Would
> it work to just have:
> 
> th, td {
> ...
> }

Done.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart:22:
@reflectable String tipTime = '';
On 2014/04/17 20:18:54, turnidge wrote:
> Is the popup tip something that should be in a custom element?  Just asking.

I'd like that at some point.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart:169: const
colors = const ['color0', 'color1', 'color2', 'color4', 'color5',
On 2014/04/17 20:18:54, turnidge wrote:
> What happened to color3? 
> 

Fixed.

> We should probably name these styles something more specific... maybe
rowColor0,
> rowColor1... dunno.
> 
> Also, if the numbers were known dense, you could avoid the lookup array:
> 
> const int maxColor = X;
> var d = row.depth - 1;
> return "rowColor${d % maxColor}";

Cheaper to index into an array of constant strings than to create a new one.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/service_error_view.html
(right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/service_error_view.html:14: </div>
On 2014/04/17 20:18:54, turnidge wrote:
> ditto comment on using the ".content" class from our browse pages.

Done.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/service_exception_view.html
(right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/service_exception_view.html:14:
</div>
On 2014/04/17 20:18:54, turnidge wrote:
> ditto ditto

Done.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/stack_trace.html (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/stack_trace.html:13: }
On 2014/04/17 20:18:54, turnidge wrote:
> We should consider moving these styles up to the shared sheet.

Done here and elsewhere.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/vm_view.html (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/vm_view.html:67: <br>
On 2014/04/17 20:18:54, turnidge wrote:
> Did you get <br>'s to look nice yet?

We should talk about styling br.

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/web/css/shared.css (right):

https://codereview.chromium.org/237683004/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/web/css/shared.css:1:
../../lib/src/elements/css/shared.css
On 2014/04/17 20:18:54, turnidge wrote:
> What's this about?

Ignore it.

[turnidge, 2014-04-21 22:29:29]

lgtm, 1 minor comment

https://codereview.chromium.org/237683004/diff/150001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/app/utils.dart (right):

https://codereview.chromium.org/237683004/diff/150001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/app/utils.dart:25: static String
formatCommaSeperated(int v) {
Seperated/Separated

[Cutch, 2014-04-22 15:03:24]

https://codereview.chromium.org/237683004/diff/150001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/app/utils.dart (right):

https://codereview.chromium.org/237683004/diff/150001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/app/utils.dart:25: static String
formatCommaSeperated(int v) {
On 2014/04/21 22:29:32, turnidge wrote:
> Seperated/Separated

Done.

[Cutch, 2014-05-06 17:08:58]

This was committed but gclient didn't close this CL or mark the SVN revision of
the commit.