Issue 23766030: Return the correct port from Uri, when port is 0 and scheme is either http or https.

Issue 23766030: Return the correct port from Uri, when port is 0 and scheme is either http or https. (Closed)

Created:
7 years, 3 months ago by Anders Johnsen

Modified:
7 years, 3 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Return the correct port from Uri, when port is 0 and scheme is either http or https. Also, always perform to-lower-case of scheme, as recommended by the spec. BUG=https://code.google.com/p/dart/issues/detail?id=13129 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27431

Patch Set 1 #

Total comments: 2

Patch Set 2 : Allow '.' in schemes. #

Patch Set 3 : Fix test. #

Total comments: 2

Patch Set 4 : Add tests and check for first charecter is alphabetic in scheme. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -24 lines)			Patch
M	sdk/lib/core/core.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/core/uri.dart	View	1 2 3	7 chunks	+21 lines, -7 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-analyzer2.status	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-co19.status	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/corelib/uri_ipv6_test.dart	View	1 2	9 chunks	+9 lines, -9 lines	0 comments	Download
M	tests/corelib/uri_path_test.dart	View	1 2	1 chunk	+1 line, -4 lines	0 comments	Download
M	tests/corelib/uri_scheme_test.dart	View	1 2 3	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/23766030/diff/1/sdk/lib/core/uri.dart File sdk/lib/core/uri.dart (right): https://codereview.chromium.org/23766030/diff/1/sdk/lib/core/uri.dart#newcode116 sdk/lib/core/uri.dart:116: this(scheme: _makeScheme(_emptyIfNull(m[_COMPONENT_SCHEME])), With this change the previous change ...

7 years, 3 months ago (2013-09-12 09:52:03 UTC) #2

Anders Johnsen

PTAL https://codereview.chromium.org/23766030/diff/1/sdk/lib/core/uri.dart File sdk/lib/core/uri.dart (right): https://codereview.chromium.org/23766030/diff/1/sdk/lib/core/uri.dart#newcode116 sdk/lib/core/uri.dart:116: this(scheme: _makeScheme(_emptyIfNull(m[_COMPONENT_SCHEME])), On 2013/09/12 09:52:03, Søren Gjesse wrote: ...

7 years, 3 months ago (2013-09-12 10:53:53 UTC) #3

Søren Gjesse

lgtm Maybe add a few more tests to uri_scheme_test.dart. https://codereview.chromium.org/23766030/diff/8001/sdk/lib/core/uri.dart File sdk/lib/core/uri.dart (right): https://codereview.chromium.org/23766030/diff/8001/sdk/lib/core/uri.dart#newcode719 sdk/lib/core/uri.dart:719: ...

7 years, 3 months ago (2013-09-12 13:03:14 UTC) #4

Anders Johnsen

Added a few tests. Landing. https://codereview.chromium.org/23766030/diff/8001/sdk/lib/core/uri.dart File sdk/lib/core/uri.dart (right): https://codereview.chromium.org/23766030/diff/8001/sdk/lib/core/uri.dart#newcode719 sdk/lib/core/uri.dart:719: '([^:/?#]+)' // scheme - ...

7 years, 3 months ago (2013-09-12 13:25:23 UTC) #5

Anders Johnsen

7 years, 3 months ago (2013-09-12 13:28:24 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r27431 (presubmit successful).

Expand Messages | Collapse Messages