Issue 23766021: Fix a bug in block reordering/block compaction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23766021: Fix a bug in block reordering/block compaction. (Closed)

Created:
7 years, 3 months ago by Kevin Millikin (Google)

Modified:
7 years, 3 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a bug in block reordering/block compaction. The compiler assumes (a) the graph entry is followed in the block order by its normal entry, and (b) the normal entry block is non-empty. There is not necessarily true, so stop assuming it. BUG=https://code.google.com/p/dart/issues/detail?id=13101 R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=27377

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -35 lines)			Patch
M	runtime/vm/compiler.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View	1 chunk	+14 lines, -11 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	4 chunks	+15 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	2 chunks	+9 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	2 chunks	+9 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	2 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

7 years, 3 months ago (2013-09-11 12:33:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27377 (presubmit successful).

Expand Messages | Collapse Messages