Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 237643003: Split analysis server's HttpAnalysisServer into two classes. (Closed)

Created:
6 years, 8 months ago by Paul Berry
Modified:
6 years, 8 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Split analysis server's HttpAnalysisServer into two classes. Behaviours of the HttpAnalysisServer which are independent of the WebSocket transport mechanism have been moved to a new class, SocketServer, which will also be used when the transport mechanism is stdio. GetHander now holds a reference to the SocketServer rather than the AnalysisServer, so that we don't need to go to extra effort to update it when the AnalysisServer is created. R=brianwilkerson@google.com, jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=35061

Patch Set 1 #

Patch Set 2 : Add missing initialization of socketServer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -44 lines) Patch
M pkg/analysis_server/lib/http_server.dart View 1 4 chunks +6 lines, -36 lines 0 comments Download
M pkg/analysis_server/lib/src/get_handler.dart View 5 chunks +7 lines, -8 lines 0 comments Download
A pkg/analysis_server/lib/src/socket_server.dart View 1 chunk +56 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/socket_server_test.dart View 1 chunk +60 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
6 years, 8 months ago (2014-04-14 22:31:42 UTC) #1
jwren
On 2014/04/14 22:31:42, Paul Berry wrote: LGTM
6 years, 8 months ago (2014-04-14 23:51:47 UTC) #2
Brian Wilkerson
Not sure how this affects extensibility, but we can always look at that again later. ...
6 years, 8 months ago (2014-04-15 00:08:55 UTC) #3
Paul Berry
6 years, 8 months ago (2014-04-15 15:41:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r35061 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698