Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 23761003: Update language.status and rewrite two tests (Closed)

Created:
7 years, 3 months ago by Søren Gjesse
Modified:
7 years, 3 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update language.status and rewrite two tests Added issue numbers Changed two negative tests into mulit-tests. R=kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26914

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -62 lines) Patch
D tests/language/constructor2_negative_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
A + tests/language/constructor9_test.dart View 1 1 chunk +5 lines, -9 lines 0 comments Download
D tests/language/constructor_return_negative_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M tests/language/constructor_return_test.dart View 1 1 chunk +9 lines, -1 line 0 comments Download
M tests/language/language_analyzer.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 2 3 chunks +21 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 3 months ago (2013-08-30 09:42:36 UTC) #1
kustermann
LGTM with comments. https://codereview.chromium.org/23761003/diff/1/tests/language/constructor9_test.dart File tests/language/constructor9_test.dart (right): https://codereview.chromium.org/23761003/diff/1/tests/language/constructor9_test.dart#newcode17 tests/language/constructor9_test.dart:17: new Klass(5); /// 01: continued Why ...
7 years, 3 months ago (2013-08-30 11:12:44 UTC) #2
Søren Gjesse
Thanks for the review. https://codereview.chromium.org/23761003/diff/1/tests/language/constructor9_test.dart File tests/language/constructor9_test.dart (right): https://codereview.chromium.org/23761003/diff/1/tests/language/constructor9_test.dart#newcode17 tests/language/constructor9_test.dart:17: new Klass(5); /// 01: continued ...
7 years, 3 months ago (2013-08-30 13:40:01 UTC) #3
Søren Gjesse
7 years, 3 months ago (2013-08-30 13:45:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r26914 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698