Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 23757034: Rearranges the polymer package now that the old compiler is gone. (Closed)

Created:
7 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rearranges the polymer package now that the old compiler is gone. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=27462

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2521 lines) Patch
M pkg/pkg.status View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/builder.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/polymer/lib/deploy.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
D pkg/polymer/lib/src/barback_runner.dart View 1 1 chunk +0 lines, -312 lines 0 comments Download
A + pkg/polymer/lib/src/build/code_extractor.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + pkg/polymer/lib/src/build/common.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + pkg/polymer/lib/src/build/import_inliner.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + pkg/polymer/lib/src/build/linter.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + pkg/polymer/lib/src/build/polyfill_injector.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + pkg/polymer/lib/src/build/runner.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + pkg/polymer/lib/src/build/script_compactor.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/src/linter.dart View 1 1 chunk +0 lines, -444 lines 0 comments Download
D pkg/polymer/lib/src/transform.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D pkg/polymer/lib/src/transform/code_extractor.dart View 1 chunk +0 lines, -83 lines 0 comments Download
D pkg/polymer/lib/src/transform/common.dart View 1 1 chunk +0 lines, -159 lines 0 comments Download
D pkg/polymer/lib/src/transform/import_inliner.dart View 1 chunk +0 lines, -172 lines 0 comments Download
D pkg/polymer/lib/src/transform/polyfill_injector.dart View 1 chunk +0 lines, -90 lines 0 comments Download
D pkg/polymer/lib/src/transform/script_compactor.dart View 1 chunk +0 lines, -128 lines 0 comments Download
A + pkg/polymer/lib/transformer.dart View 1 1 chunk +10 lines, -10 lines 0 comments Download
A + pkg/polymer/test/build/all_phases_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/polymer/test/build/code_extractor_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/polymer/test/build/common.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + pkg/polymer/test/build/import_inliner_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/polymer/test/build/linter_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/polymer/test/build/polyfill_injector_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/polymer/test/build/script_compactor_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
D pkg/polymer/test/build/utils_test.dart View 1 1 chunk +0 lines, -86 lines 0 comments Download
M pkg/polymer/test/transform/all_phases_test.dart View 1 1 chunk +0 lines, -218 lines 0 comments Download
M pkg/polymer/test/transform/code_extractor_test.dart View 1 1 chunk +0 lines, -112 lines 0 comments Download
D pkg/polymer/test/transform/common.dart View 1 1 chunk +0 lines, -111 lines 0 comments Download
M pkg/polymer/test/transform/import_inliner_test.dart View 1 1 chunk +0 lines, -372 lines 0 comments Download
M pkg/polymer/test/transform/polyfill_injector_test.dart View 1 1 chunk +0 lines, -61 lines 0 comments Download
M pkg/polymer/test/transform/script_compactor_test.dart View 1 1 chunk +0 lines, -99 lines 0 comments Download
A + pkg/polymer/test/utils_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Siggi Cherem (dart-lang)
no code changes here, just moving things around.
7 years, 3 months ago (2013-09-12 01:46:38 UTC) #1
Jennifer Messerly
hmm, to be honest I kinda liked the organization of having the build steps separate ...
7 years, 3 months ago (2013-09-12 02:54:21 UTC) #2
Siggi Cherem (dart-lang)
Part of the reason I was moving things up is that besides 'utils.dart', we don't ...
7 years, 3 months ago (2013-09-12 16:58:48 UTC) #3
Siggi Cherem (dart-lang)
PTAL - I just rearranged things as we discussed and did a couple more moves. ...
7 years, 3 months ago (2013-09-12 23:46:56 UTC) #4
Jennifer Messerly
lgtm!
7 years, 3 months ago (2013-09-12 23:59:12 UTC) #5
Siggi Cherem (dart-lang)
7 years, 3 months ago (2013-09-13 00:18:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r27462 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698