Simplify compilation of relational operators.

Simplify compilation of relational operators.

Instead of having a separate IL instructions relational comparisons
are built as normal instance calls initially. When optimized, we replace
the instance call with a smi/double/mint comparison instruction.

This enables generic inlining of relational operator calls and simplifies
code generation, too.

Merging comparisons with branches is done in the optimizing compiler's
branch simplification phase.

R=kmillikin@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27058

[Kevin Millikin (Google), 2013-09-03 13:23:54]

lgtm

https://codereview.chromium.org/23757016/diff/1/runtime/vm/flow_graph_builder.cc
File runtime/vm/flow_graph_builder.cc (right):

https://codereview.chromium.org/23757016/diff/1/runtime/vm/flow_graph_builder...
runtime/vm/flow_graph_builder.cc:1442: Symbols::New(Token::Str(node->kind()))),
node->Name() is the same as Token::Str(node->kind()).

https://codereview.chromium.org/23757016/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/23757016/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:1112: // We cannot use double comparison on
two Smi-s. Need polymorphic
I see that you didn't write this comment in this change, but smi is not a proper
noun, and its plural is just "smis" :)

https://codereview.chromium.org/23757016/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/23757016/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.h:3011: deopt_id_ = deopt_id;
You can just set this in the member initializer list (assuming set_operation_cid
doesn't need to see the old value).

[Florian Schneider, 2013-09-03 13:55:06]

https://codereview.chromium.org/23757016/diff/1/runtime/vm/flow_graph_builder.cc
File runtime/vm/flow_graph_builder.cc (right):

https://codereview.chromium.org/23757016/diff/1/runtime/vm/flow_graph_builder...
runtime/vm/flow_graph_builder.cc:1442: Symbols::New(Token::Str(node->kind()))),
On 2013/09/03 13:23:55, kmillikin wrote:
> node->Name() is the same as Token::Str(node->kind()).

Done.

https://codereview.chromium.org/23757016/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/23757016/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:1112: // We cannot use double comparison on
two Smi-s. Need polymorphic
On 2013/09/03 13:23:55, kmillikin wrote:
> I see that you didn't write this comment in this change, but smi is not a
proper
> noun, and its plural is just "smis" :)

Done.

https://codereview.chromium.org/23757016/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/23757016/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.h:3011: deopt_id_ = deopt_id;
On 2013/09/03 13:23:55, kmillikin wrote:
> You can just set this in the member initializer list (assuming
set_operation_cid
> doesn't need to see the old value).

Unfortunately it won't work with a private field of a super-class.

[Florian Schneider, 2013-09-03 14:03:09]

Committed patchset #2 manually as r27058 (presubmit successful).