Issue 23757005: - Fix double-increment in bignum library code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23757005: - Fix double-increment in bignum library code. (Closed)

Created:
7 years, 3 months ago by Ivan Posva

Modified:
7 years, 3 months ago

Reviewers:
floitsch, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Siggi Cherem (dart-lang)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Fix double-increment in bignum library code. Committed: https://code.google.com/p/dart/source/detail?r=26881

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	runtime/third_party/double-conversion/src/bignum.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

7 years, 3 months ago (2013-08-30 07:43:54 UTC) #4

Message was sent while issue was closed.

LGTM.
fwiw this has been fixed in the double-conversion repository some time ago.
This specific case is unreachable, but still good it's gone now. (I didn't
change our version, to avoid diverging from the initial import of the
third-party library.)

Expand Messages | Collapse Messages